Convert from command to site-type #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
rahulsprajapati
suggested changes
Aug 29, 2018
src/WP.php
Outdated
| @@ -16,7 +16,7 @@ | |||
| * | |||
| * @package ee-cli | |||
| */ | |||
| class Site_WP_Command extends EE_Site_Command { | |||
| class WP extends EE_Site_Command { | |||
There was a problem hiding this comment.
Now that class name is not long we can use WordPress as the class name. Please update it as WordPress and rename file to wordpress.php.
src/WP.php
Outdated
| if ( ! EE::exec( $core_download_command ) ) { | ||
| EE::error('Unable to download wp core.', false ); | ||
| if ( ! \EE::exec( $core_download_command ) ) { | ||
| \EE::error('Unable to download wp core.', false ); | ||
| } | ||
|
|
||
| // TODO: Look for better way to handle mysql healthcheck |
There was a problem hiding this comment.
Do we have some issue for this in our repo? If not please create one so that it won't lost in code itself.
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
Signed-off-by: Riddhesh Sanghvi <[email protected]>
rahulsprajapati
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: https://travis-ci.org/mrrobot47/easyengine/builds/421700140