common/amount: prevent scaling with invalid factors in amount scale functions #8306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions Changelog-Fixed: Add checks in `amount_msat_scale` and `amount_sat_scale` to return false when the scaling factor is -NaN or negative. This is important as the scaling factor may come from external sources like wire, which can cause runtime errors if not handled properly.
|
ACK 2bd8caf |
morehouse
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks in
amount_msat_scale()andamount_sat_scale()to return false when the scaling factor is -NaN or negative.This is important as the scaling factor may come from external sources like wire, which can cause runtime errors if not handled properly.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: