Fix #640: Transform Images of Meetup section to <Image>-Component #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nifty-bardeen-5c7e53 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
andygrunwald
force-pushed
the
meetups-images-issue-640
branch
from
faf3f81 to
9e60cf6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes Meetup images under src/content/meetup/images, switches all markdown references to use those relative paths, updates the content schema to use Astro’s image helper, and updates components to render optimized <Image> imports.
- Moved logos and avatars into
src/content/meetup/images/...and updated all markdown frontmatter paths - Refactored
config.tsschema to useimage().optional()forlogoandavatar - Updated components (
Talk.astro,CompanyLogo.astro, listing/archive views) to use<Image>and pass sizing props
Reviewed Changes
Copilot reviewed 101 out of 101 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/content/meetup/*.md | Updated all logo/avatar paths to ./images/... |
| src/content/config.ts | Switched logo and avatar schema to image().optional() |
| src/components/Talk.astro | Replaced <img> with <Image> for speaker avatars |
| src/components/CompanyLogo.astro | Switched to <Image> and added logoHeight prop |
| src/components/meetup-alps/*.astro | Updated listings and sponsor components to pass logoHeight and use <Image> |
Comments suppressed due to low confidence (1)
src/components/CompanyLogo.astro:16
- For any
<a target="_blank">, addrel="noopener noreferrer"to prevent reverse tabnabbing vulnerabilities.
<a href={url} target="_blank">
Comment on lines
+8
to
+11
| logoHeight: number; | ||
| } | ||
|
|
||
| const { name, logo, url } = Astro.props; | ||
| const logoURL = logo ? `/meetup/alps/images/location/${logo}` : null; | ||
|
|
||
| const { name, logo, url, logoHeight } = Astro.props; |
There was a problem hiding this comment.
[nitpick] Consider making logoHeight optional with a sensible default, so that consumers aren’t required to specify it on every <CompanyLogo> usage.
Copilot uses AI. Check for mistakes.
timhannemann
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #640
One big change is that we move the images from
public/meetup/alps=>src/content/meetup/images/.We also resolve one duplication of the
ibk-Image.