Skip to content

Adds a k8s deployment for the app, and updates Sonarcloud #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Jul 15, 2020
Merged

Adds a k8s deployment for the app, and updates Sonarcloud #18

merged 50 commits into from
Jul 15, 2020

Conversation

ElvenSpellmaker
Copy link
Contributor

📲 What

Adds Infra and App deployment to the pipeline.

Also re-works Sonarscanner to work with Branches and PRs. (might need further tweaking due to refs/heads

🤔 Why

We need our infra deployed and proper branch analysis on Sonarcloud.

👀 Evidence

image
Now supports branches

🕵️ How to test

Notes for QA

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

ElvenSpellmaker and others added 30 commits July 12, 2020 17:49
@ElvenSpellmaker
Feat: Adds TF validation to build, adds infr dply
5efd826
@ElvenSpellmaker
Merge branch 'master' of github.com:amido/stacks-java into feature/de…
c6238df 
…ployment
@ElvenSpellmaker
Merge branch 'master' of github.com:amido/stacks-java into feature/de…
ef3e3bc 
…ployment
@ElvenSpellmaker
fix: Use new way of deploying infra
2b057eb
@ElvenSpellmaker
fix: create_cdn_endpoint missing
c07fc8a
@dnitsch
fix: update modules
e6f3966
@dnitsch
merge from branch
22936db
@dnitsch
fix characters not wrapped in string
81c5377
@dnitsch
fix: silly errors
f3cbcf9
@dnitsch
fix: DNS groups
5a31626
@dnitsch
fix: acr pointer
cba26a8
@dnitsch
fix: deployemt api version updated
ac7c482
@ElvenSpellmaker
feat: try deploying app
5b31355
@ElvenSpellmaker
fix: more deploy stuff
a907f06
@ElvenSpellmaker
fix: terraform fmt
0fb5bc2
@ElvenSpellmaker
fix: add unit to rollout status timeout
39f44fa
@ElvenSpellmaker
fix: adds Cosmos stuff, comments out configmap
fe5e499
@ElvenSpellmaker
fix: deploy fix
5d22417
@ElvenSpellmaker
fix: more fixes
0d2917e
@dnitsch
fix: test redirect with app path specified
967823b
@ElvenSpellmaker
fix: move variable up
caabfdb
@ElvenSpellmaker
fix: changes rewrite groups to $$1
ad3d518
@dnitsch
fix: pass app insights key in memory
8085cbb
@dnitsch
chore: merge upstream branch
06c6033
@ElvenSpellmaker
fix: tf linting
4daf5eb
@dnitsch
fix: path deploy
41988a7
@dnitsch
fix: location for cosmos
5e7c40f
@ElvenSpellmaker
fix: ups timeout, attempts sonar fix, bn move
df1054c
@ElvenSpellmaker
fix: move parameter to runtime
e0c7de0
@ElvenSpellmaker
fix: close coalesce... DOH!
faf3a11
@ElvenSpellmaker ElvenSpellmaker changed the title Feature/deployment Adds a k8s deployment for the app, and updates Sonarcloud Jul 14, 2020
dnitsch
dnitsch reviewed Jul 15, 2020
View reviewed changes
@Ensono Ensono deleted a comment from ElvenSpellmaker Jul 15, 2020
@Ensono Ensono deleted a comment from ElvenSpellmaker Jul 15, 2020
dnitsch
dnitsch reviewed Jul 15, 2020
View reviewed changes
dnitsch
dnitsch reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@dnitsch dnitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments for discussion.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ElvenSpellmaker ElvenSpellmaker merged commit 5e4ea49 into master Jul 15, 2020
@ElvenSpellmaker ElvenSpellmaker deleted the feature/deployment branch July 15, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnitsch dnitsch dnitsch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElvenSpellmaker @dnitsch