Applying suggestion in #545 on creating instance of action class

[viktorcsimma]

See #545.

Summary by CodeRabbit

• Bug Fixes
  • Improved the logic for notifying users about end-of-semester questionnaires to ensure more reliable checks on controller activity.

[coderabbitai]

Walkthrough

The update in the NotifyAboutEvaluation.php middleware refines how the SemesterEvaluationController is instantiated. Instead of directly creating a new instance of the controller, the application now uses the Laravel app() helper function to resolve the controller from the service container. This ensures that any dependencies required by the controller are properly injected, improving the flexibility and maintainability of the code.

Changes

File	Change Summary
app/Http/Middleware/NotifyAboutEvaluation.php	Replaced new SemesterEvaluationController() with app(SemesterEvaluationController::class) in the handle method.

Sequence Diagram

sequenceDiagram
    participant User
    participant Middleware
    participant AppContainer
    participant SemesterEvaluationController

    User ->> Middleware: Request
    Middleware ->> AppContainer: Resolve SemesterEvaluationController
    AppContainer ->> Middleware: Return Instance
    Middleware ->> SemesterEvaluationController: Check if active
    SemesterEvaluationController -->> Middleware: Return Status
    Middleware -->> User: Proceed with request

Loading

Poem

In the realm of code so vast and grand,
A tweak was made with careful hand.
No more new controllers, that's the key,
Now app() ensures dependency.
The flow is smooth, the code refined,
With Laravel's magic intertwined.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[horcsinbalint]

I will check if it works on staging

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c833cd8 and 3ccf9fb.

Files selected for processing (1)

• app/Http/Middleware/NotifyAboutEvaluation.php (1 hunks)

Additional comments not posted (1)

app/Http/Middleware/NotifyAboutEvaluation.php (1)

30-32: Change to use Laravel's service container is a good practice.

It's great to see the use of app(...) for dependency resolution, which enhances testability and maintainability. Consider adding a comment explaining why app(...) is preferred over direct instantiation for future maintainers.

[viktorcsimma]

@horcsinbalint I've logged in to staging; it seems to be fine now.