Adds support for armor trims and custom patterns for date and time keywords. #6155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR addresses issues reported on Discord, documented in #5799, and encountered personally when using armor trims in kits and even worse with with keywords. While enabling use-nbt-serialization-in-createkit fixed the trim issue, it prevented the use of keywords in item lore. Additionally, I've added support for customizable date and time keyword patterns, a feature recently requested by Discord users.
Proposed feature:
Add compatibility with armor trims in kits and introduce customizable patterns for
date
andtime
keywords.Environments tested:
OS: Ubuntu 22.04 LTS and Windows 10.
Java version: ❯
openjdk 21.0.6 2025-01-21 LTS
OpenJDK Runtime Environment Zulu21.40+17-CA (build 21.0.6+7-LTS)
OpenJDK 64-Bit Server VM Zulu21.40+17-CA (build 21.0.6+7-LTS, mixed mode, sharing)
Demonstration:
Create a kit that contains armor with trim and you will get a result similar to this:
Trim format:
pattern|material
The supported patterns and materials are basically what Minecraft has available. The format created is self-sustaining and does not depend on a list, so when Minecraft updates, the list of supported patterns and materials will update.