Skip to content

Adds support for armor trims and custom patterns for date and time keywords. #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

0ff1
Copy link

@0ff1 0ff1 commented May 27, 2025

Details

This PR addresses issues reported on Discord, documented in #5799, and encountered personally when using armor trims in kits and even worse with with keywords. While enabling use-nbt-serialization-in-createkit fixed the trim issue, it prevented the use of keywords in item lore. Additionally, I've added support for customizable date and time keyword patterns, a feature recently requested by Discord users.

Proposed feature:
Add compatibility with armor trims in kits and introduce customizable patterns for date and time keywords.

Environments tested:

OS: Ubuntu 22.04 LTS and Windows 10.

Java version: ❯
openjdk 21.0.6 2025-01-21 LTS
OpenJDK Runtime Environment Zulu21.40+17-CA (build 21.0.6+7-LTS)
OpenJDK 64-Bit Server VM Zulu21.40+17-CA (build 21.0.6+7-LTS, mixed mode, sharing)

  • Paper 1.21.4 - 231

Demonstration:
Create a kit that contains armor with trim and you will get a result similar to this:

demonstration:
    delay: 0
    items:
    - netherite_boots 1 trim:silence|gold
    - netherite_leggings 1 trim:wayfinder|diamond
    - netherite_chestplate 1 trim:dune|emerald
    - netherite_helmet 1 trim:sentry|redstone

Trim format: pattern|material

The supported patterns and materials are basically what Minecraft has available. The format created is self-sustaining and does not depend on a list, so when Minecraft updates, the list of supported patterns and materials will update.

@mdcfe mdcfe self-requested a review June 14, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant