Skip to content

Dmonsewicz/updating with upstream #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 18, 2020

Conversation

dennismonsewicz
Copy link

No description provided.

aqeelvn and others added 22 commits March 2, 2018 18:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Here we should use SassC, that's whole point :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
https-ify sass-lang.com urls

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix the ordering so that more specialised files are correctly picked

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This part of the code was still referencing an older Sass Ruby constant path
Fixes sass#128

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Correct reference to SassC::Script::Value::String
Rails 6 is currently at an RC1. This should allow any beta or release candidate version without needing to update it.

The jruby build fails as it can't find a compatible rails 6 release. Since this installs jruby 9.1, perhaps rails 6 only supports jruby 9.2 (latest)? https://travis-ci.org/sass/sassc-rails/jobs/554811782
With the previous change we were only running CI builds against 3.0.x max.
This was many minor versions behind. We want to ensure our CI uses the current minor version.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update Travis with Rails 6 and to use all current minor releases
@dennismonsewicz dennismonsewicz requested a review from jasich June 18, 2020 14:32
@dennismonsewicz dennismonsewicz self-assigned this Jun 18, 2020
@dennismonsewicz dennismonsewicz merged commit 3e76e42 into master Jun 18, 2020
@dennismonsewicz dennismonsewicz deleted the dmonsewicz/updating-with-upstream branch June 18, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants