-
-
Notifications
You must be signed in to change notification settings - Fork 190
Dev/testing impl step 1 #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The SVG now covers all floorplan-services:
But, I still need to test the objects exposed within custom JS:
I didn't mean to close the PR. The UI jumped, while I did try and press "Update comment". |
|
|
Test Results 2 files 8 suites 45s ⏱️ Results for commit f0f7016. ♻️ This comment has been updated with latest results. |
|
Today's work does add:
Before merging, I'd like to:
As mentioned before: It would also be great to have some sort of testing within Home Assistant, but that's for another day. |
|
Today I've introduced:
Things to be considered for iteration 2:
|
First iteration of introducing tests for ha-floorplan.
This is by no mean finished, and I need to look more into
playwright, in order to validate if it's actually needed to have both a dedicated end-to-end test (browser based), and a simple dom-solution in test (like ´@testing-library/jest-dom` already used in the Jest tests).The PR also touches quite a few components, in order to make test possible.
There's still a long way to go, for every feature to be tested; and done the most efficient way. But, this is the beginning.
I'll revisit this in a few days, and if I don't see anything problematic, I'll merge it, and keep working in a new branch, once I found time to do so.