Issue 244 #271
Issue 244 #271
Conversation
somya51p
force-pushed
the
issue-244
branch
2 times, most recently
from
922e7a6 to
a2ce653
Compare
.github/workflows/yarn.yml
Outdated
| cmd: install # will run `yarn install` command | ||
| - uses: borales/[email protected] | ||
| with: | ||
| cmd: build # will run `yarn build` command |
There was a problem hiding this comment.
yarn build is not necessary. Also, please remove redundant comments.
.github/workflows/yarn.yml
Outdated
| @@ -0,0 +1,24 @@ | |||
| name: yarn | |||
There was a problem hiding this comment.
It might be better to include this as a separate job of ci.yml, as a job called test, and then create a job dependency so that the container image build step depends on test. This would prevent non-working builds from being published.
.github/workflows/ci.yml
Outdated
| @@ -13,6 +13,16 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| steps: | |||
|
|
|||
| - name: test | |||
There was a problem hiding this comment.
the name "test" does not seem to be describing actions/checkout@v2
.github/workflows/ci.yml
Outdated
|
|
||
| - name: test | ||
| uses: actions/checkout@v2 | ||
| uses: borales/[email protected] |
There was a problem hiding this comment.
From the README:
Please keep in mind that this Action was originally written for GitHub Actions beta (when Docker was the only way of doing things). Consider using actions/setup-node to work with Yarn. This repository will be mostly supporting the existing flows.
|
@jennydaman Can you please review the changes I recently made? I need a bit of help with this issue. |
|
@jennydaman As discussed in the meeting, I reviewed the test results based on previous commits and concluded that the latest changes would work accurately. Please review the same and let me know if I am wrong. |
@jennydaman Added yarn test with Github Actions to check if the
yarnis built successfully, ignoring the test results.Please check if this would work.