Fix: Bubble component typing regression#2639
Merged
Merged
Conversation
PR FaridSafi#2609 introduced a regression in the types by migrating the Bubble component from a class component to using React.FC, which does not support generics. This commit replaces React.FC with generics and a JSX.Element return type on the Bubble component, allowing to keep the function component and bringing back the type argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2609 introduced a type regression by migrating the Bubble component from a class component to a function component using React.FC, which does not support generics.
This commit replaces
React.FCwith generics and aJSX.Elementreturn type on the Bubble component, allowing to keep the function component and bringing back the type argument. The type argument here is necessary to provide accurate type information for non-vanilla messages.Since generics are used quite extensively on this project especially around message object customization, I recommend to steer away from using
React.FCfor consistency's sake.For those wanting to use a ready-to-go patch using patch-package for example, here you go:
react-native-gifted-chat+2.8.1.patch
@kesha-antonov feel free to review and provide feedback, I might have missed some things or reasons why you decided to went with React.FC in the first place here.