[WIP] gifted chat automatically scrolled to bottom bug#2651
Merged
Conversation
Co-authored-by: kesha-antonov <11584712+kesha-antonov@users.noreply.github.com>
Copilot stopped work on behalf of
kesha-antonov due to an error
August 28, 2025 16:14
kesha-antonov
approved these changes
Aug 28, 2025
Collaborator
|
@copilot merge master |
Contributor
Author
Hi! Could you clarify what you'd like me to do regarding master? Are you asking me to:
I want to make sure I address your request properly. |
Collaborator
|
@copilot merge master |
…nges Co-authored-by: kesha-antonov <11584712+kesha-antonov@users.noreply.github.com>
Contributor
Author
Merged master successfully! The branch now includes the latest upstream changes from master (TypeScript types fixes and ESLint error fixes) while preserving our fix for the scroll-to-bottom issue. All tests continue to pass (29/29) and no new linting errors were introduced. The merge commit is e5cac52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for gifted chat automatically scrolled to bottom bug when isScrollToBottomEnabled=false
Plan:
Changes Made:
onLayoutListcallback inMessageContainer/index.tsxto checkisScrollToBottomEnabledbefore performing automatic scroll to bottomisScrollToBottomEnabledto the condition at line 245 and to the dependency array at line 252isScrollToBottomEnabled={false}, the chat will not automatically scroll to bottom on layoutTesting:
inverted={false}andisScrollToBottomEnabled={false}: NO automatic scroll (✅ FIXED)inverted={false}andisScrollToBottomEnabled={true}: automatic scroll still works (✅ PRESERVED)inverted={true}: unchanged (✅ PRESERVED)The fix is minimal and surgical - only 2 lines changed to respect the user's explicit intent when they disable scroll-to-bottom functionality.
Fixes #2611.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.