Fix false positives of "missing entries for record X" error during index validation when a deleted record version is committed and has a backversion#7694
Merged
ilya071294 merged 1 commit intoFirebirdSQL:masterfrom Aug 7, 2023
Conversation
…dex validation when a deleted record version is committed and has a backversion The existence of an index entry is not required for such version chain because it is all garbage since a transaction is committed. To reproduce the false positive, the server should be stopped just after the chain is garbage-collected and an index page is written to disk.
hvlad
approved these changes
Aug 3, 2023
aafemt
reviewed
Aug 3, 2023
| if (header->rhd_b_page && !deleted_flag) | ||
| RBM_SET(pool, &vdr_rel_records, number.getValue()); | ||
| else if ((header->rhd_flags & rhd_deleted) == 0) | ||
| else if (header->rhd_b_page || !deleted_flag) |
Contributor
There was a problem hiding this comment.
Both ifs contain condition header->rhd_b_page. Cannot they be replaced with single if?
Contributor
Author
There was a problem hiding this comment.
I think I tried it before and it led to unnecessary code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existence of an index entry is not required for such version chain because it is all garbage since a transaction is committed. To reproduce the false positive, the server should be stopped just after the chain is garbage-collected and an index page is written to disk.