Wire protocol improvement: prefetch blob info and some data when open blob#8307
Merged
hvlad merged 3 commits intov5.0-releasefrom Nov 6, 2024
Merged
Wire protocol improvement: prefetch blob info and some data when open blob#8307hvlad merged 3 commits intov5.0-releasefrom
hvlad merged 3 commits intov5.0-releasefrom
Conversation
…ical packet. It allows to prefetch and cache blob info and some blob data in single network roundtrip. Return cached blob info, if present, without remote access.
asfernandes
reviewed
Nov 6, 2024
asfernandes
reviewed
Nov 6, 2024
dyemanov
reviewed
Nov 6, 2024
dyemanov
reviewed
Nov 6, 2024
aafemt
reviewed
Nov 6, 2024
AlexPeshkoff
reviewed
Nov 6, 2024
Fixed typo. Thanks to @dyemanov for comments.
Contributor
|
5.0.0? May be 5.0.2? |
hvlad
added
fix-version: 5.0 RC 2
fix-version: 5.0.2
and removed
fix-version: 5.0.0
fix-version: 5.0 RC 2
labels
Member
Author
Sure, thanks |
|
It is valid to mention that initial tests in high latency network (ping 149ms) show an average transfer speed improvement of 33-49% with this patch. |
TreeHunter9
reviewed
Nov 7, 2024
hvlad
added a commit
that referenced
this pull request
Nov 7, 2024
… blob (#8307) * Group op_open_blob2, op_info_blob and op_get_segment into single physical packet. It allows to prefetch and cache blob info and some blob data in single network roundtrip. Return cached blob info, if present, without remote access. * No need to reserve space for segment length. Fixed typo. Thanks to @dyemanov for comments. * Add 'const' for parameter declaration, as @AlexPeshkoff suggested * Use 'if constexpr' as @TreeHunter9 suggested. Also, avoid hardcoded constants when possible.
mrotteveel
added
the
rlsnotes60: no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of wire protocol improvements with regards to reading blobs.
In this part I offer to group op_open_blob2, op_info_blob and op_get_segment logical packets into single physical packet.
It allows to prefetch and cache blob info and some blob data (up to 16KB currently) in single network roundtrip.
If application ask for blob info after open - return cached blob info without remote access.
This patch requires no protocol changes, no server code changes and should be fully compatible with older Firebird servers.