Skip to content

Php 7.4 Incompatibility Fixes #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

pathumhdes
Copy link
Contributor

  1. Passing the $glue and $pieces parameters in reverse order to implode has been deprecated since PHP 7.4; $glue should be the first parameter and $pieces the second
  2. Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4

@mkopinsky
Copy link
Contributor

It looks like travis tests failed because of a network fluke. Could one of you retrigger the tests?

Copy link
Contributor

@mkopinsky mkopinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spirit-q2
Copy link

spirit-q2 commented May 6, 2020

@pathumhdes just squash two of your three commits and it will trigger re-run of the tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix array and string offset access using curly braces (Deprecated since PHP 7.4)

Fix array and string offset access using curly braces (Deprecated since PHP 7.4)

PHP 7.4 incompatibility fix: Passing the glue and pieces parameters in reverse order to implode has been deprecated since PHP 7.4
@pathumhdes
Copy link
Contributor Author

@spirit-q2 @mkopinsky The tests are passing now.

Copy link
Contributor

@mentalstring mentalstring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a couple of really small tweaks, but otherwise it looks good.

@j0k3r
Copy link
Contributor

j0k3r commented Jun 8, 2020

I was wondering why is there nothing about these Incompatibilities reported in Travis log?
https://travis-ci.org/github/FriendsOfSymfony1/symfony1/jobs/670507708

I there no test to cover each case? If so, would you mind adding some?

@j0k3r j0k3r self-assigned this Jun 8, 2020
@thePanz thePanz self-requested a review June 8, 2020 07:10
@j0k3r j0k3r merged commit 19aee49 into FriendsOfSymfony1:master Jun 8, 2020
@pathumhdes pathumhdes deleted the php-7.4 branch June 8, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants