- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 181
Php 7.4 Incompatibility Fixes #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pathumhdes
commented
May 2, 2020
- Passing the $glue and $pieces parameters in reverse order to implode has been deprecated since PHP 7.4; $glue should be the first parameter and $pieces the second
- Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4
It looks like travis tests failed because of a network fluke. Could one of you retrigger the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pathumhdes just squash two of your three commits and it will trigger re-run of the tests |
Fix array and string offset access using curly braces (Deprecated since PHP 7.4) Fix array and string offset access using curly braces (Deprecated since PHP 7.4) PHP 7.4 incompatibility fix: Passing the glue and pieces parameters in reverse order to implode has been deprecated since PHP 7.4
@spirit-q2 @mkopinsky The tests are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a couple of really small tweaks, but otherwise it looks good.
I was wondering why is there nothing about these Incompatibilities reported in Travis log? I there no test to cover each case? If so, would you mind adding some? |