fix(visitors): asynchronize callback having no param other than error #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <[email protected]>
merge master into develop
Co-authored-by: Renovate Bot <[email protected]>
* chore(deps): update typescript-eslint monorepo to v3 * chore(*): update submodules * chore(*): disable rule '@typescript-eslint/camelcase' * chore(*): update eslint rules * disable '@typescript-eslint/explicit-module-boundary-types' * enable '@typescript-eslint/naming-convention' Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Kosaku Kimura <[email protected]>
* fix(deps): update babel monorepo to ^7.10.3 * fix(visitors): fix type guards * chore(examples): update submodules * chore(testing): use .mocharc.js * chore(lint): ignore package.json and package-lock.json * feat(visitors): improve type checking for general-callback functions * chore(testing): fix glob pattern Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Kosaku Kimura <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
* chore(deps): update dependency @types/js-yaml to v3.12.5 * chore(index): add type assertion for ServerlessConfig Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Kosaku Kimura <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 74.98% 78.02% +3.04%
==========================================
Files 26 26
Lines 1371 1370 -1
Branches 289 286 -3
==========================================
+ Hits 1028 1069 +41
+ Misses 226 191 -35
+ Partials 117 110 -7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.