Skip to content

Support one script operator deployment #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Conversation

RobertIndie
Copy link
Contributor

No description provided.

@RobertIndie RobertIndie requested a review from Copilot June 29, 2025 04:33
@RobertIndie RobertIndie self-assigned this Jun 29, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR supports a unified script operator deployment by introducing a consolidated deployment YAML and updating chart configuration and RBAC resource names for consistent naming. Key changes include the addition of an operator deployment YAML file, the introduction of a new createNamespace value in the Helm chart, and the renaming of several RBAC and deployment resources for consistency.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

File Description
operator/scripts/deploy.yaml Adds comprehensive operator deployment resources generated from Helm templates.
operator/deploy/chart/values.yaml Introduces a new createNamespace flag to control namespace creation.
Various chart templates (rbac, namespace, manager, etc.) Renames resources to follow a consistent naming convention.
operator/Makefile Adds a new target to generate the deploy YAML using helm template with appropriate flags.
Comments suppressed due to low confidence (2)

operator/deploy/chart/values.yaml:44

  • [nitpick] Consider adding inline documentation for the new 'createNamespace' field to clarify its usage and default behavior for users deploying the chart.
createNamespace: false

operator/deploy/chart/templates/manager/manager.yaml:4

  • [nitpick] Verify that the change of the deployment name from 'operator-controller-manager' to 'function-stream' is intentional and consistently aligned with the naming of other operator resources.
  name: function-stream

@RobertIndie RobertIndie merged commit 9393c4b into main Jun 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant