Handling ordered deprecation
#130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
jamesbraza
approved these changes
Nov 28, 2024
src/aviary/env.py
Outdated
| @@ -177,6 +178,12 @@ async def exec_tool_calls( | |||
| Ordered list of ToolResponseMessages, order matches the order of tool calls | |||
| in the input message. | |||
| """ | |||
| if (ordered := function_kwargs.pop("ordered", None)) is not None: | |||
There was a problem hiding this comment.
Check https://github.com/Future-House/aviary-internal/pull/930, Future-House/paper-qa#728
We already changed all users, I vote we just skip this deprecation.
Defer to you though, approved
There was a problem hiding this comment.
Nice, I think that covers all our bases. Removing the deprecation
dosubot
bot
added
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123 removed the
orderedflag, but not all downstream environments have been updated. To deal with this, I am bringing the flag back and throwing a warning. We can properly deprecate it once everything has been updated.I'm also fixing HotPotQA here for good measure.