DocMetadataClient can now take instantiated providers and processors
#414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
jamesbraza
reviewed
Sep 14, 2024
jamesbraza
reviewed
Sep 16, 2024
| @pytest.mark.asyncio | ||
| async def test_crossref_retraction_status(): | ||
| async with aiohttp.ClientSession() as session: | ||
| retract_processor = RetractionDataPostProcessor( | ||
| "stub_data/stub_retractions.csv" |
There was a problem hiding this comment.
Okay running tests locally after this PR, we are now hitting issues as this is a relative path ungrounded in the system.
Can you move this test to intake the fixture stub_data_dir:
async def test_crossref_retraction_status(stub_data_dir: Path):
async with aiohttp.ClientSession() as session:
retract_processor = RetractionDataPostProcessor(
stub_data_dir / "stub_retractions.csv"
)
...Also, it looks like this test creates a 163 MB cassette. That is too big. Why is this test making a fixture still, when we are passing in a retractions CSV?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.