Truncating failing test_evaluation via max_rollout_steps
#475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
dosubot
bot
added
size:M
whitead
approved these changes
Sep 24, 2024
jamesbraza
force-pushed
the
faster-test-evaluation
branch
from
eebc756 to
49a7463
Compare
jamesbraza
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this CI run, we see:
Nearly 2 hours! I observed locally it's possible for our indexing process to not find a piece of data in the
stub_datafolder, leading to infinite "failed to answer" loops.Normal behavior should concluded a rollout in 3 actions (one search, one gather, one answer), so this PR just truncates long rollouts by specifying a
max_rollout_stepsof 10.