Implemented __deepcopy__ on all Environments
#614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
jamesbraza
commented
Oct 19, 2024
jamesbraza
commented
Oct 19, 2024
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_deepcopy_env(agent_test_settings: Settings) -> None: |
There was a problem hiding this comment.
This unit test should be considered really baller
mskarlin
approved these changes
Oct 19, 2024
|
|
||
| def __deepcopy__(self, memo) -> Self: | ||
| copy_state = deepcopy(self.state, memo) | ||
| # We don't know the side effects of deep copying a litellm.Router, |
jamesbraza
force-pushed
the
env-copying
branch
from
0a79341 to
6b17656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__deepcopy__onPaperQAEnvironmentandGradablePaperQAEnvironment, with a testmake_tools, so I decomposedPaperQAEnvironment.make_initial_state_and_toolsfor it. Note this is a breaking changeLitQAEvaluation.from_question, as its inner workings were requiring too much thoughtmodel_confignot being at the top I missed in Moved Pydanticmodel_configto top of each class #607