Skip to content

Printing the text in a failed llm_parse_json #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Printing the text in a failed llm_parse_json #629

merged 1 commit into from
Oct 23, 2024

Conversation

jamesbraza
Copy link
Collaborator

Making it possible to debug llm_parse_json failures

@jamesbraza jamesbraza added the bug Something isn't working label Oct 23, 2024
@jamesbraza jamesbraza self-assigned this Oct 23, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 23, 2024
whitead
whitead approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do not like this function. Think it's too restrictive to blow up on parse error, but obv unrelated to this PR

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 23, 2024
@jamesbraza jamesbraza merged commit 327a5c0 into main Oct 23, 2024
5 checks passed
@jamesbraza jamesbraza deleted the showing-input-failure-json branch October 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead