Skip to content

Deprecation cycle for AgentSettings.should_pre_search #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jamesbraza
Copy link
Collaborator

Starting a deprecation cycle for a dead agent setting that should have been removed within #358

@jamesbraza jamesbraza added the bug Something isn't working label Nov 13, 2024
@jamesbraza jamesbraza self-assigned this Nov 13, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@jamesbraza jamesbraza merged commit b90c625 into main Nov 13, 2024
5 checks passed
@jamesbraza jamesbraza deleted the deprecating-should-pre-search branch November 13, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants