Refactor to remove skip_system from LLMModel.run_prompt
#680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
7 tasks
maykcaldas
added a commit
that referenced
this pull request
Nov 16, 2024
…ke it compatible with #680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading through our various control flows here, I found the presence of a system prompt coupled with a
skip_systemflag to add more thought and complexity. We don't need to cart around two separate pieces of information here, we can just makesystem_promptbe an optional variable and one source of truth.This PR is a refactor that removes
skip_systemin favor ofboolchecks directly onsystem_prompt. Yes it's a breaking change, but I don't think ourLLMModelimplementation is really imported and used by our users.