Skip to content

Resolving evidence_detailed_citations and Answer deprecations #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jamesbraza
Copy link
Collaborator

Seen in CI logs (link):

tests/test_configs.py: 2 warnings
tests/test_paperqa.py: 26 warnings
tests/test_cli.py: 10 warnings
tests/test_agents.py: 2 warnings
  /home/runner/work/paper-qa/paper-qa/.venv/lib/python3.11/site-packages/pydantic/main.py:212: DeprecationWarning: The 'evidence_detailed_citations' field is deprecated and will be removed in version 6. Adjust 'PromptSettings.context_inner' to remove detailed citations.
    validated_self = self.__pydantic_validator__.validate_python(data, self_instance=self)

tests/test_paperqa.py::test_answer_rename
  /home/runner/work/paper-qa/paper-qa/tests/test_paperqa.py:1136: DeprecationWarning: The 'Answer' class is deprecated and will be removed in future versions. Use 'PQASession' instead.
    answer = Answer(question="")

This PR:

@jamesbraza jamesbraza added the bug Something isn't working label Nov 13, 2024
@jamesbraza jamesbraza self-assigned this Nov 13, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 13, 2024
@jamesbraza jamesbraza force-pushed the resolving-deprecations branch from f9f7e7d to 1a74625 Compare November 13, 2024 21:59
Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@jamesbraza jamesbraza merged commit 3c63433 into main Nov 13, 2024
5 checks passed
@jamesbraza jamesbraza deleted the resolving-deprecations branch November 13, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants