Allowing serialized Settings in get_settings
#688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
nadolskit
approved these changes
Nov 15, 2024
mskarlin
reviewed
Nov 15, 2024
paperqa/settings.py
Outdated
|
|
||
|
|
||
| def get_settings(config_or_name: MaybeSettings = None) -> Settings: | ||
| if isinstance(config_or_name, Settings): | ||
| return config_or_name | ||
| if isinstance(config_or_name, dict): | ||
| return Settings(**config_or_name) |
There was a problem hiding this comment.
nit but I'm more partial to .model_validate
There was a problem hiding this comment.
Alright moved to it 👌
Out of curiosity, why do you prefer model_validate here? I was playing around, and couldn't actually find a place where Settings(**config_or_name) validation fails while Settings.model_validate(config_or_name) succeeds
mskarlin
approved these changes
Nov 15, 2024
jamesbraza
force-pushed
the
supporting-dict-settings
branch
from
b43ebe0 to
6a6d273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to use this function with config files