Fixed LDP runner's TRUNCATED not calling gen_answer, and documented AgentStatus
#690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
nadolskit
approved these changes
Nov 15, 2024
mskarlin
reviewed
Nov 15, 2024
| logger.exception("Trajectory failed.") | ||
| status = AgentStatus.FAIL | ||
| if status == AgentStatus.TRUNCATED: | ||
| # Fail over after truncation (too many steps, timeout): just answer |
mskarlin
approved these changes
Nov 15, 2024
jamesbraza
force-pushed
the
removing-failed-to-answer
branch
from
f9ad07e to
0ab2b13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_answerfailover logic so that all runners call it, which inadvertently fixes the LDP runner not callinggen_answerupon truncationAgentStatusenum values a bit moreTODOfor it to be renamed