Skip to content

Refactored TestGradablePaperQAEnvironment for DRY code #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

Refactored TestGradablePaperQAEnvironment for DRY code #702

merged 2 commits into from
Nov 19, 2024

Conversation

jamesbraza
Copy link
Collaborator

  • Moved test_sequential_tool_calls into TestGradablePaperQAEnvironment
  • Refactored out stub_gradable_env fixture

@jamesbraza jamesbraza added the enhancement New feature or request label Nov 19, 2024
@jamesbraza jamesbraza self-assigned this Nov 19, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@jamesbraza jamesbraza merged commit 25a62d1 into main Nov 19, 2024
5 checks passed
@jamesbraza jamesbraza deleted the refactoring-test-env branch November 19, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

@maykcaldas maykcaldas Awaiting requested review from maykcaldas

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead