Skip to content

Fixed settings session into EnvironmentState, and suppressing PyMuPDF derived DeprecationWarning #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fixed settings session into EnvironmentState, and suppressing PyMuPDF derived DeprecationWarning #713

merged 3 commits into from
Nov 20, 2024

Conversation

jamesbraza
Copy link
Collaborator

  • Renamed to PQASession type #653 forgot to add populate_by_name=True to EnvironmentState when adding the alias
  • Suppressing a swig DeprecationWarning that is an upstream of PyMuPDF

@jamesbraza jamesbraza added the bug Something isn't working label Nov 20, 2024
@jamesbraza jamesbraza self-assigned this Nov 20, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2024
@jamesbraza jamesbraza merged commit cef9e2e into main Nov 20, 2024
5 checks passed
@jamesbraza jamesbraza deleted the fixing-typing branch November 20, 2024 20:57
@maykcaldas maykcaldas mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maykcaldas maykcaldas maykcaldas approved these changes

@whitead whitead Awaiting requested review from whitead

@mskarlin mskarlin Awaiting requested review from mskarlin

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @maykcaldas