Skip to content

Supporting Python 3.13 #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Supporting Python 3.13 #946

merged 3 commits into from
May 20, 2025

Conversation

jamesbraza
Copy link
Collaborator

The final straw for Python 3.13 support has fallen into place: quickwit-oss/tantivy-py#401.

We lagged Python 3.13's release by ~7 months, not bad.

CI will pass as soon as https://github.com/quickwit-oss/tantivy-py cuts a release.

@jamesbraza jamesbraza self-assigned this May 5, 2025
@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 23:48
@jamesbraza jamesbraza added the enhancement New feature or request label May 5, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project configuration to support Python 3.13.

  • Updated pyproject.toml to include Python 3.13 in the classifiers.
  • Modified the CI workflow to test against Python 3.13.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Added Python 3.13 classifier to reflect updated language support.
.github/workflows/tests.yml Updated the Python version matrix to test with Python 3.13.
Files not reviewed (1)
  • .python-version: Language not supported

@jamesbraza jamesbraza marked this pull request as draft May 5, 2025 23:53
@wallies
Copy link

wallies commented May 6, 2025

@jamesbraza https://github.com/quickwit-oss/tantivy-py/releases/tag/0.24.0

@jamesbraza jamesbraza marked this pull request as ready for review May 6, 2025 20:53
@jamesbraza
Copy link
Collaborator Author

@jamesbraza quickwit-oss/tantivy-py@0.24.0 (release)

Nice work with the release @wallies , yep CI passes now 🥳

Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME WORK!!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2025
@jamesbraza jamesbraza merged commit 25aea9f into main May 20, 2025
5 checks passed
@jamesbraza jamesbraza deleted the py313 branch May 20, 2025 05:46
@jamesbraza jamesbraza mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants