-
Notifications
You must be signed in to change notification settings - Fork 22
[BUG] Some editions present in openlibrary missing from Yamtrack #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fixed in v0.23.0 |
Thank you for this! All editions seem now present in the "Other editions" section when a book is selected! However, after playing a bit with the demo, I still find the workflow not very usable. When I search for "饥饿游戏", the only search result is still the generic same item. While I can find and click on the desired edition in the "Other Editions" section of this item, it's not as straightforward as having the result directly in the search results, especially when I'm searching for the exact name/reference/ISBN of the edition I'm interested with. Let's say I've got this edition, with ISBN 9781338321913, that I would like to add in Yamtrack. Currently, looking for this edition can be quite difficult in Yamtrack, as searching with this specific ISBN will bring up that same item. Then I have to look in the "Other Editions" section of this item, trying to recognize the edition I'm looking from by only looking at titles/covers, which can be quite long, given that I already know exactly which edition I'm targeting as I have its ISBN. However, I get that it might not be as straightforward as it seems, as I'm completely unfamiliar with the OpenLibrary API. The search seems to work somewhat, as it brings up the correct work, however it does not bring up the required edition of this work, and scrolling through other editions can be quite tedious. I can open a new issue if you prefer. |
I have made some modifications, now the Yamtrack book search results should look more like the results from the OpenLibrary website. |
This is perfect! Now a title/ISBN search always brings up the required item! Thank you for your work! |
Describe the bug
Some books/editions, altough present on openlibrary database, do not show up on Yamtrack's search.
To Reproduce
Look at the following book on openlibrary: https://openlibrary.org/works/OL5735363W/The_Hunger_Games?edition=jieyouxii0001coll
When searching for "饥饿游戏" on Yamtrack (openlibrary tab), the only result showing up seems to be an "Hunger Games" entry, which makes sense, but it is not the edition I'm looking for.
I can also try to search for "jieyouxii0001coll" (present in the openlibrary's URL), but same behaviour: only a single "Hunger Games" entry shows up, and not this specific edition.
Same behaviour when I'm search for ISBN of specific editions, the same single entry shows up.
When I click this entry, I'm proposed for a couple of alternative editions, but this specific one is not there. On openlibrary, I can see that there are 131 different editions of this book, and only 10 are displayed in Yamtrack.
Another example that I cannot find on Yamtrack: https://openlibrary.org/books/OL35302690M/A%C3%A7l%C4%B1k_Oyunlar%C4%B1_1
Expected behavior
I would expect all editions to show up in the results, or at least in the "Other Editions" section in the work if you do not want to display all editions directly in the search.
Yamtrack version:
Demo version on your website (v0.22.7-20-g992aafd)
The text was updated successfully, but these errors were encountered: