Skip to content

fix: copy data into tooler #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2022
Merged

fix: copy data into tooler #113

merged 3 commits into from
Nov 2, 2022

Conversation

buschNT
Copy link
Collaborator

@buschNT buschNT commented Nov 2, 2022

  • helm source with path option failed to copy data correctly
  • targetRevision defaulted to "" which caused a git checkout error

@buschNT
fix: copy data into tooler
af62b78 
- helm source with path option failed to copy data correctly
- targetRevision defaulted to "" which caused a git checkout error
@buschNT
fix: source_path none
0648854
@buschNT
fix: print debug location
9323eff
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3379400167

  • 9 of 19 (47.37%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 65.552%
Changes Missing Coverage Covered Lines Changed/Added Lines %
getdeck/sources/tooler.py 4 5 80.0%
getdeck/fetch/source_fetcher.py 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
getdeck/fetch/source_fetcher.py 1 61.54%
getdeck/utils.py 12 54.2%
Totals Coverage Status
Change from base Build 3348319713: -0.1%
Covered Lines: 1353
Relevant Lines: 2064
💛 - Coveralls

@buschNT buschNT merged commit 9780068 into main Nov 2, 2022
@buschNT buschNT deleted the bugfix/helm-tooler-copy-data branch November 3, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buschNT @coveralls