-
Notifications
You must be signed in to change notification settings - Fork 469
Add a new attribution build for debugging issues in the field #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/* | ||
Copyright 2022 Google LLC | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
https://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
export * from './dist/modules/attribution.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
Copyright 2022 Google LLC | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
https://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
// Creates the `web-vitals/attribution` import in node-based bundlers. | ||
// This will not be needed when export maps are widely supported. | ||
export * from './dist/web-vitals.attribution.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,16 @@ | ||
/* | ||
Copyright 2022 Google LLC | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
https://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
export * from './dist/modules/index.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,18 @@ | ||
/* | ||
Copyright 2022 Google LLC | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
https://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
// Creates the `web-vitals/base` import in node-based bundlers. | ||
// This will not be needed when export maps are widely supported. | ||
export * from './dist/web-vitals.base.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Copyright 2022 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
export {onCLS} from './attribution/onCLS.js'; | ||
export {onFCP} from './attribution/onFCP.js'; | ||
export {onFID} from './attribution/onFID.js'; | ||
export {onINP} from './attribution/onINP.js'; | ||
export {onLCP} from './attribution/onLCP.js'; | ||
export {onTTFB} from './attribution/onTTFB.js'; | ||
|
||
export * from './types.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/* | ||
* Copyright 2022 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import {getLoadState} from '../lib/getLoadState.js'; | ||
import {getSelector} from '../lib/getSelector.js'; | ||
import {onCLS as unattributedOnCLS} from '../onCLS.js'; | ||
import {CLSAttribution, CLSReportCallback, CLSReportCallbackWithAttribution, CLSMetric, CLSMetricWithAttribution, ReportOpts} from '../types.js'; | ||
|
||
|
||
const getLargestLayoutShiftEntry = (entries: LayoutShift[]) => { | ||
return entries.reduce((a, b) => a && a.value > b.value ? a : b); | ||
} | ||
|
||
const getLargestLayoutShiftSource = (sources: LayoutShiftAttribution[]) => { | ||
return sources.find((s) => s.node && s.node.nodeType === 1) || sources[0]; | ||
} | ||
|
||
const attributeCLS = (metric: CLSMetric): CLSMetricWithAttribution => { | ||
let attribution: CLSAttribution = {}; | ||
if (metric.entries.length) { | ||
const largestEntry = getLargestLayoutShiftEntry(metric.entries); | ||
if (largestEntry && largestEntry.sources && largestEntry.sources.length) { | ||
const largestSource = getLargestLayoutShiftSource(largestEntry.sources); | ||
if (largestSource) { | ||
attribution = { | ||
largestShiftTarget: getSelector(largestSource.node), | ||
largestShiftTime: largestEntry.startTime, | ||
largestShiftValue: largestEntry.value, | ||
largestShiftSource: largestSource, | ||
largestShiftEntry: largestEntry, | ||
loadState: getLoadState(largestEntry.startTime), | ||
}; | ||
} | ||
} | ||
} | ||
return Object.assign(metric, {attribution}); | ||
} | ||
|
||
/** | ||
* Calculates the [CLS](https://web.dev/cls/) value for the current page and | ||
* calls the `callback` function once the value is ready to be reported, along | ||
* with all `layout-shift` performance entries that were used in the metric | ||
* value calculation. The reported value is a `double` (corresponding to a | ||
* [layout shift score](https://web.dev/cls/#layout-shift-score)). | ||
* | ||
* If the `reportAllChanges` configuration option is set to `true`, the | ||
* `callback` function will be called as soon as the value is initially | ||
* determined as well as any time the value changes throughout the page | ||
* lifespan. | ||
* | ||
* _**Important:** CLS should be continually monitored for changes throughout | ||
* the entire lifespan of a page—including if the user returns to the page after | ||
* it's been hidden/backgrounded. However, since browsers often [will not fire | ||
* additional callbacks once the user has backgrounded a | ||
* page](https://developer.chrome.com/blog/page-lifecycle-api/#advice-hidden), | ||
* `callback` is always called when the page's visibility state changes to | ||
* hidden. As a result, the `callback` function might be called multiple times | ||
* during the same page load._ | ||
*/ | ||
export const onCLS = (onReport: CLSReportCallbackWithAttribution, opts?: ReportOpts) => { | ||
unattributedOnCLS(((metric: CLSMetric) => { | ||
onReport(attributeCLS(metric)); | ||
}) as CLSReportCallback, opts); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/* | ||
* Copyright 2022 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import {getBFCacheRestoreTime} from '../lib/bfcache.js'; | ||
import {getLoadState} from '../lib/getLoadState.js'; | ||
import {getNavigationEntry} from '../lib/getNavigationEntry.js'; | ||
import {onFCP as unattributedOnFCP} from '../onFCP.js'; | ||
import {FCPMetricWithAttribution, FCPReportCallback, FCPReportCallbackWithAttribution, ReportOpts} from '../types.js'; | ||
|
||
|
||
const attributeFCP = (metric: FCPMetricWithAttribution): void => { | ||
if (metric.entries.length) { | ||
const navigationEntry = getNavigationEntry(); | ||
const fcpEntry = metric.entries[metric.entries.length - 1]; | ||
|
||
if (navigationEntry) { | ||
const activationStart = navigationEntry.activationStart || 0; | ||
const ttfb = Math.max(0, navigationEntry.responseStart - activationStart); | ||
|
||
metric.attribution = { | ||
timeToFirstByte: ttfb, | ||
firstByteToFCP: metric.value - ttfb, | ||
loadState: getLoadState(metric.entries[0].startTime), | ||
navigationEntry, | ||
fcpEntry, | ||
}; | ||
} | ||
} else { | ||
// There are no entries when restored from bfcache. | ||
metric.attribution = { | ||
timeToFirstByte: 0, | ||
firstByteToFCP: metric.value, | ||
loadState: getLoadState(getBFCacheRestoreTime()), | ||
}; | ||
} | ||
}; | ||
|
||
/** | ||
* Calculates the [FCP](https://web.dev/fcp/) value for the current page and | ||
* calls the `callback` function once the value is ready, along with the | ||
* relevant `paint` performance entry used to determine the value. The reported | ||
* value is a `DOMHighResTimeStamp`. | ||
*/ | ||
export const onFCP = (onReport: FCPReportCallbackWithAttribution, opts?: ReportOpts) => { | ||
unattributedOnFCP(((metric: FCPMetricWithAttribution) => { | ||
attributeFCP(metric); | ||
onReport(metric); | ||
}) as FCPReportCallback, opts); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.