Kubernetes V1.18 support for CRD

[KamalAman]

I'm trying to install this operator of my kubernetes cluster running v1.18.6 however I am getting the following error

Error: failed to create resource: CustomResourceDefinition.apiextensions.k8s.io "flinkclusters.flinkoperator.k8s.io" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[job].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property, spec.validation.openAPIV3Schema.properties[spec].properties[taskManager].properties[sidecars].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property, spec.validation.openAPIV3Schema.properties[spec].properties[taskManager].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property, spec.validation.openAPIV3Schema.properties[spec].properties[jobManager].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property, spec.validation.openAPIV3Schema.properties[spec].properties[jobManager].properties[sidecars].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property]

The root cause of the issue is that V1.18 added CRDs validation #91395

This can be easily resolved by adding the protocol to the required fields for the item properties

                        required:
                          - containerPort
                          - protocol
                          type: object
                        type: array
                        x-kubernetes-list-map-keys:
                        - containerPort
                        - protocol

[functicons]

Could you help fix it? Thanks!

[diskun00]

After change the controller-gen version and put protocol as required in flink-cluster-crd.yaml, I can successfully install flink operator by helm in Kubernetes v1.18.8 .

[technomage]

Please post your changes. That file is >3000 lines and is blocking any work getting done at the moment on this.

[technomage]

I was able to get it to deploy using the changes above, making protocol required.

[EnriqueL8]

Has this change been merged?

[elanv]

Controller-tools 0.4.1, which fixes this issue, has been released. However, this only applies to CRD v1. (Now we use v1beta1.)

Not only that, but CRD v1 restricts the "k8s.io" API domain for custom resources.
We use API group domain "flinkoperator.k8s.io", so it is likely that should be approved to use or the domain needs to be changed.

Note: kubernetes/enhancements#1111

[elanv]

dup of #266 and workaround #266 (comment)