Skip to content

chore: Update release job configs #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Feb 26, 2025

Details:

  • Switched release job to use the dedicated release image instead of the one shared with CI jobs
  • Stopped loading docuploader_credentials from secret manager since we don't push docs as part of the release
  • Stopped installing toys from the release script since it is present in the image already
  • Stopped uploading documentation to googleapis.dev since that site is defunct for Ruby docs

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dazuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the release job configurations. It switches the release job to use a dedicated release image, stops loading docuploader credentials from the secret manager, stops installing toys from the release script, and stops uploading documentation to googleapis.dev. These changes aim to streamline the release process and reduce unnecessary steps.

Highlights

  • Image Update: The release job now uses the ruby-release image instead of the shared ruby-multi image.
  • Credential Management: The job no longer loads docuploader_credentials from the secret manager.
  • Dependency Management: The release script no longer installs the toys gem, assuming it's pre-installed in the release image.
  • Documentation Upload: The job no longer uploads documentation to googleapis.dev.

Changelog

  • .kokoro/release.cfg
    • Changed the TRAMPOLINE_IMAGE environment variable to use the ruby-release image (line 16).
    • Removed docuploader_service_account from the SECRET_MANAGER_KEYS environment variable (line 31).
  • .kokoro/release.sh
    • Removed the gem install --no-document toys command (line 10).
    • Removed the --enable-docs flag from the toys release perform command (line 11).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is the purpose of the toys gem in the context of Ruby releases?

Click here for the answer
The `toys` gem likely provides tooling and automation for performing release-related tasks, such as versioning, building, and publishing.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release job configurations, switching to a dedicated release image, stopping the loading of docuploader credentials, stopping the installation of toys, and stopping the uploading of documentation. The changes seem reasonable and improve the release process by using a dedicated image and removing unnecessary steps. However, I have a few suggestions for improvement.

Summary of Findings

Assessment

The pull request is well-structured and addresses the intended changes effectively. The use of a dedicated release image and the removal of unnecessary steps contribute to a more streamlined release process. I recommend addressing the comments before merging, and ensuring that others review and approve this code before merging.

@dazuma dazuma requested a review from aandreassa February 26, 2025 22:42
@dazuma dazuma merged commit 2d665ef into GoogleCloudPlatform:main Feb 26, 2025
19 of 20 checks passed
@dazuma dazuma deleted the pr/release-jobs branch February 27, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants