chore: Work around an annoying rubocop change #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aandreassa
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Style/RedundantConditioncop seems to be flagging this case now. I would argue it's a false positive, but I'm not confident that viewpoint will be popular enough to force rubocop to revert its behavior. Unfortunately there doesn't seem to be a good alternative for this functionality that isn't also flagged by rubocop. I've made the judgment call that reverting to the "double-negative" idiom is probably the best option that preserves the intent while minimizing the blast radius of disabling a rubocop check. This of course has no functional impact on the code; hence I'm classifying it as "chore:" for conventional commit purposes.