Skip to content

Wrong algorithm name using the KeyFactory #1010

Closed
@FlorianTim

Description

@FlorianTim
Contributor

java-docs-samples\iot\api-client\manager\src\main\java\com\example\cloud\iot\examples\MqttExample.java

from: KeyFactory kf = KeyFactory.getInstance("ES256");
to: KeyFactory kf = KeyFactory.getInstance("EC");

EC is the right name for the Elliptic Curve algorithm.

https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#KeyFactory

Activity

lesv

lesv commented on Jan 28, 2018

@lesv
Contributor

@gguuss Can you comment?

gguuss

gguuss commented on Jan 30, 2018

@gguuss
Contributor

I believe the JWT-based ES256 is correct , I may actually have the readme / documentation wrong and should correct that.

gguuss

gguuss commented on Jan 30, 2018

@gguuss
Contributor

That said, the tests still pass and your pointer to the docs corroborates your point. I'll look into why the tests pass in both cases as we're testing adding EC and RSA devices.

gguuss

gguuss commented on Jan 30, 2018

@gguuss
Contributor

Tested end-to-end and working for me, approving.

nnegrey

nnegrey commented on Dec 5, 2018

@nnegrey
Contributor

This appears to have been resolved, closing the issue.

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @lesv@gguuss@nnegrey@FlorianTim

      Issue actions

        Wrong algorithm name using the KeyFactory · Issue #1010 · GoogleCloudPlatform/java-docs-samples