dialogflow: delete samples that are not in docs #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t are broken after the deletions
googlebot
added
the
cla: yes
nnegrey
changed the title
lesv
reviewed
Apr 10, 2020
Comment on lines
44
to
45
| private static String TEST_KNOWLEDGE_BASE_ID = "MTA4MzE0ODY5NTczMTQzNzU2ODA"; | ||
| private static String TEST_DOCUMENT_ID = "MTUwNjk0ODg1NTU4NzkzMDExMg"; |
There was a problem hiding this comment.
Should we be concerned about these constants and running testing jobs in parallel. (ie. j8 & j11)
There was a problem hiding this comment.
Not for this one. I used to have these tests dynamically create these resources, but the API has to do some ML training for an indeterminate time on the created resources which would create a flaky test occasionally. There are some more involved work-arounds to get around this, but would significantly complicate the tests.
So instead having this resource be static and used for "prediction" should handle any number of parallel requests and all of them should get an identical response and only a change to the Document we created should break this.
lesv
approved these changes
Apr 10, 2020
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
* dialogflow: delete samples that are not in docs and fix the tests that are broken after the deletions * update README
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
* dialogflow: delete samples that are not in docs and fix the tests that are broken after the deletions * update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the tests that are broken after the deletions
Update this PR: #2483
Fixes #2252