Skip to content

fix(meta): enhance mysql election client with timeouts and reconnection #6341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2025

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 18, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR enhances the reliability of the MySQL election client by adding timeouts and reconnection mechanisms. The changes address two critical issues:

  • The election client not reconnecting after connection loss
  • Missing query/execution timeouts causing potential hangs

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions bot added size/M docs-not-required This change does not impact docs. labels Jun 18, 2025
@WenyXu WenyXu mentioned this pull request Jun 19, 2025
18 tasks
@github-actions github-actions bot added size/L and removed size/M labels Jun 19, 2025
@WenyXu WenyXu marked this pull request as ready for review June 19, 2025 08:26
@WenyXu WenyXu requested a review from MichaelScofield as a code owner June 19, 2025 08:26
@WenyXu WenyXu force-pushed the fix/mysql-election-client branch from 4e951ec to f98ae8a Compare June 19, 2025 08:29
@WenyXu WenyXu force-pushed the fix/mysql-election-client branch from 6b4095f to 9e7beb8 Compare June 19, 2025 09:16
@github-actions github-actions bot added size/M and removed size/L labels Jun 19, 2025
@WenyXu WenyXu force-pushed the fix/mysql-election-client branch from 9dbada8 to bf65ffc Compare June 19, 2025 10:57
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@WenyXu WenyXu force-pushed the fix/mysql-election-client branch from 42eff15 to 2c338c2 Compare June 19, 2025 12:25
@WenyXu WenyXu enabled auto-merge June 19, 2025 12:25
@WenyXu WenyXu added this pull request to the merge queue Jun 19, 2025
Merged via the queue into GreptimeTeam:main with commit 89e3c8e Jun 19, 2025
41 checks passed
@WenyXu WenyXu deleted the fix/mysql-election-client branch June 19, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants