-
Notifications
You must be signed in to change notification settings - Fork 384
feat: implement automatic region failure detector registrations #6370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fa07e9
to
e3b0897
Compare
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
a6e0841
to
366d9ab
Compare
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
366d9ab
to
01c9808
Compare
fengjiachun
reviewed
Jun 23, 2025
921de82
to
9c22ec8
Compare
Signed-off-by: WenyXu <[email protected]>
9c22ec8
to
60d50bd
Compare
Signed-off-by: WenyXu <[email protected]>
fengjiachun
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MichaelScofield
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR adds automatic region failure detector registrations. The metasrv now automatically discovers and registers failure detectors for all regions found in table routes, and ensures that metasrv leader will only register once throughout its lifecycle.
Configuration changes:
region_failure_detector_initialization_delay
option.This delay helps prevent premature initialization of region failure detectors in cases where cluster maintenance mode is enabled right after metasrv starts, especially when the cluster is not deployed via the recommended GreptimeDB Operator. Without this delay, early detector registration may trigger unnecessary region failovers during datanode startup.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.