fix(metric-engine): handle stale metadata region recovery failures #6395
+140
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
docs-not-required
WenyXu
changed the title
Signed-off-by: WenyXu <[email protected]>
WenyXu
force-pushed
the
fix/stale-metadata-region
branch
from
a72752a to
2fb96dd
Compare
WenyXu
force-pushed
the
fix/stale-metadata-region
branch
from
60bff85 to
cfcad14
Compare
Signed-off-by: WenyXu <[email protected]>
WenyXu
force-pushed
the
fix/stale-metadata-region
branch
from
cfcad14 to
c11b7b8
Compare
killme2008
reviewed
Jun 27, 2025
| // If the metadata region is opened with a stale manifest, | ||
| // the metric engine may fail to recover logical tables from the metadata region, | ||
| // as the manifest could reference files that have already been deleted | ||
| // due to compaction operations performed by the region leader. |
There was a problem hiding this comment.
I'm not sure we can repair the metadata in this case; it appears to be expected and may occur.
There was a problem hiding this comment.
After the region leader completes compaction, the old manifest reference files (i.e., compaction inputs) are deleted from object storage. In this case, If a region still holds a stale manifest, we need to close it first. Otherwise, during migration retries, it will keep reopening the same stale state and fail again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
fixes #6273
What's changed and what's your intention?
This PR addresses a issue in the metric engine where stale metadata regions could cause recovery failures, leading to orphaned regions.
close_physical_region_on_recovery_failuremethod to handle cleanup on recovery failuresProblem
When the metadata region is opened with a stale manifest, the metric engine may fail to recover logical tables from the metadata region. This happens because the manifest could reference files that have already been deleted due to compaction operations performed by the region leader. In such cases, the recovery process fails but the region(metadata/data region) remains open. When the upper layer retries the operation, it will still fail because the stale metadata region hasn't been closed by the metric engine.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.