Repository navigation
fix: report unsupported source-only RAG text scope - #2379
Merged
pancacake merged 2 commits intoNov 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Open
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A RAG call with only
source_pathenters visual inspection and reportsreference_required, even for a plain text question. Returnsource_scope_unsupportedafter the existing KB access check and run no retrieval, so the requested source boundary is never dropped.This implements the explicit unsupported-scope option in #2374. Strict document-scoped semantic retrieval remains unavailable through this tool. Explicit visual selectors, figure references and inferred English/Chinese page references retain their existing behavior. Update the parameter description and both language hints to explain this contract.
Related Issues
Fixes #2374.
Module(s) Affected
toolsservicestestsValidation
On macOS arm64 with standalone CPython 3.12.14 and Redis 7.4:
The full suite exited successfully but emitted a pending-task shutdown diagnostic for
TurnLifecycle._flush_live_prefix; its baseline status was not checked.Regression tests cover unsupported text scope, null/empty selectors, source hashes, access denial, inferred pages and ordinary unscoped queries. The original scope error and the page-inference regression were each observed failing before their respective fixes. The upstream Python/OS CI matrix remains to run.
Checklist
dev.