feat: Update full-text index name to include workspace label for bett… #2406
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ): | ||
| """Create a full-text index on the entity_id property with Chinese tokenizer support.""" | ||
| index_name = "entity_id_fulltext_idx" | ||
| index_name = f"entity_id_fulltext_idx_{workspace_label}" |
There was a problem hiding this comment.
The full-text index is now created as entity_id_fulltext_idx_{workspace_label}, but search_labels still calls db.index.fulltext.queryNodes with the hard-coded name entity_id_fulltext_idx (see around line 1644), so on any newly created workspace where only the workspace-specific index exists, queries will throw IndexNotFound and always fall back to the slower CONTAINS-based path. The new index is never used, negating the change and degrading search performance for new databases.
Useful? React with 👍 / 👎.
|
After renaming the index, data migration must also be considered to ensure that indexes in legacy systems are properly updated to the new name. |
Co-authored-by: netbrah <[email protected]>
Co-authored-by: netbrah <[email protected]>
2 participants
This pull request makes a small but important change to the naming convention for full-text indexes in the Neo4j implementation. The index name now includes the
workspace_label, ensuring that each workspace has a uniquely named index and preventing potential naming conflicts.index_namein the_create_fulltext_indexmethod oflightrag/kg/neo4j_impl.pynow incorporates theworkspace_label, making the index name workspace-specific.Description
[Briefly describe the changes made in this pull request.]
Related Issues
[Reference any related issues or tasks addressed by this pull request.]
Changes Made
[List the specific changes made in this pull request.]
Checklist
Additional Notes
[Add any additional notes or context for the reviewer(s).]