[deepseek_r1] refine _schedule_prefills for prompts with large length range #1511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefill batch size is usually controlled by
max_num_batched_tokens
which must be larger thanmax_model_len
. For a set of requests with large variance of lengthens, themax_num_batched_tokens
must be larger thanmax(seq_lens)
. Which leads to large batchsize for the short requests and hurt TTFT performance.In this PR
max_num_batched_tokens>=max_model_len
is removed.seq_len > max_num_batched_tokens
, the prefill batch size will be 1.seq_len > max_num_batched_tokens
will be skipped if there are prefills already scheduled, and the following requests will be checked and scheduled if possible.In this way, the
max_num_batched_tokens
should be chosen as the minimum length that could fully utilize the device, and the recommended value is 8192.This PR is tested with the following example code:
The results from high-level profile: