warm up done #236
Open
warm up done #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiko-bkr
approved these changes
Apr 6, 2025
Comment on lines
+6
to
+8
| function checkIfNumber(arg) { | ||
| return !isNaN(parseFloat(arg)) && isFinite(arg); | ||
| }; |
Comment on lines
+10
to
+13
| function getAVG(args) { | ||
| const sum = args.reduce((acc, arg) => acc + parseFloat(arg), 0); | ||
| return sum / args.length; | ||
| } |
There was a problem hiding this comment.
Nice! The casing of the name of the function is a bit odd though, it should be either getAvg or getAverage in my opinion.
|
|
||
|
|
||
|
|
||
| console.log(main(args)); |
There was a problem hiding this comment.
What is the motivation for this console.log? You already do all the printing in the main() function itself, this line of code will either output an unncesessary undefined or a duplicate value for average, which was already printed. You can remove this.
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "start": "node avg.js" |
There was a problem hiding this comment.
As you did not need any npm dependencies for your code, there is no need to make this code into an npm package through npm init. It would have been enough to just run your code via node avg.js in the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the delay.