Skip to content

Fix remove dev dependency laravel-langscanner from production #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jakob-info
Copy link
Contributor

@jakob-info jakob-info commented Apr 9, 2025

Summary

The php dependency "druc/laravel-langscanner" got moved into development dependencies. Fixes #479

Checklist

  • [x ] I have read the contributing guidelines.
  • [x ] My code is of good quality and follows the coding standards of the project.
  • [x ] I have tested my changes, and they work as expected.

Thank you for your contribution! 🎉

Copy link
Contributor

github-actions bot commented Apr 9, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jakob-info
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@daveearley
Copy link
Contributor

Well spotted. Thanks for this!

@daveearley daveearley merged commit 4fa5793 into HiEventsDev:develop Apr 10, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛Dev dependency laravel-langscanner gets installed in production
2 participants