Conversation
this doesn't fix any thing but ensures that we get rid of error once and for all
hf-kklein
approved these changes
Sep 11, 2023
Contributor
hf-kklein
left a comment
hf-kklein
left a comment
There was a problem hiding this comment.
Ehrlich gesagt hab' ichs nicht selbst gedebuggt, aber wenn es den Test besteht, und sonst nichts kaputt macht dann passt das 👍
Ein paar anmerkungen hatte ich noch. Kannst du die noch einbauen?
| As above, the results are written into rows, sub_rows and multi_step_instructions. Those will be modified. | ||
| """ | ||
| use_cases: List[str] = [] | ||
| # first init |
Contributor
There was a problem hiding this comment.
Suggested change
| # first init |
| enhanced_table_row.cells[len(use_cases) + self._column_index_check_result] | ||
| ) | ||
|
|
||
| if row_index == len(self._enhance_list_view(table=table, row_offset=row_offset)) - 1: |
Contributor
There was a problem hiding this comment.
Suggested change
| if row_index == len(self._enhance_list_view(table=table, row_offset=row_offset)) - 1: | |
| this_is_the_last_row = row_index == len(self._enhance_list_view(table=table, row_offset=row_offset)) - 1 | |
| if this_is_the_last_row: |
das ist mehr readable.
| """ | ||
| use_cases: List[str] = [] | ||
| # first init | ||
| enhanced_table_row = self._enhance_list_view(table=table, row_offset=row_offset)[row_index] |
Contributor
There was a problem hiding this comment.
magst du das self._enhance_list_view(table=table, row_offset=row_offset) noch in eine variable mit lesbasrem namen verpacken?
du verwendest es ja an 4 stellen im nachfolgenden.
| def _handle_single_table_star_exception( | ||
| self, | ||
| table: Table, | ||
| multi_step_instructions: List[MultiStepInstruction], |
Contributor
There was a problem hiding this comment.
Suggested change
| multi_step_instructions: List[MultiStepInstruction], | |
| multi_step_instructions: list[MultiStepInstruction], |
| table: Table, | ||
| multi_step_instructions: List[MultiStepInstruction], | ||
| row_offset: int, | ||
| rows: List[EbdTableRow], |
Contributor
There was a problem hiding this comment.
Suggested change
| rows: List[EbdTableRow], | |
| rows: list[EbdTableRow], |
| with several instructions. Those instructions will be split in individual steps. | ||
| As above, the results are written into rows, sub_rows and multi_step_instructions. Those will be modified. | ||
| """ | ||
| use_cases: List[str] = [] |
Contributor
There was a problem hiding this comment.
Suggested change
| use_cases: List[str] = [] | |
| use_cases: list[str] = [] |
| star_case_note = enhanced_table_row.cells[len(use_cases) + self._column_index_note].text.strip() or None | ||
| while row_index < len(self._enhance_list_view(table=table, row_offset=row_offset)): | ||
| enhanced_table_row = self._enhance_list_view(table=table, row_offset=row_offset)[row_index] | ||
| step_number = str(int(rows[-1].step_number) + 1) |
Contributor
There was a problem hiding this comment.
Suggested change
| step_number = str(int(rows[-1].step_number) + 1) | |
| step_number = str(int(last(rows).step_number) + 1) |
find ich lesbarer. ist aber nicht wichtig
hf-kklein
changed the title
"*" in step_number
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.