Skip to content

✨ Implement Scraping of use_cases (the gray outer left cells)#18

Merged
hf-kklein merged 16 commits intomainfrom
graph014a
Jan 2, 2023
Merged

✨ Implement Scraping of use_cases (the gray outer left cells)#18
hf-kklein merged 16 commits intomainfrom
graph014a

Conversation

@hf-kklein
Copy link
Copy Markdown
Contributor

@hf-kklein hf-kklein commented Dec 27, 2022

Fixes #16
based on #17 (<-- review this first)
Also this is based on the model PRs:

which I published as pre-release ebdtable2graph v0.1.4a

Comment thread requirements.in Outdated
@hf-kklein hf-kklein self-assigned this Dec 27, 2022
@hf-kklein hf-kklein linked an issue Dec 27, 2022 that may be closed by this pull request
Comment thread unittests/examples.py
check_result=EbdCheckResult(result=False, subsequent_step_number="17"), result_code=None, note=None
),
],
use_cases=["Einzug"],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier gehts los, der interessante teil

Base automatically changed from e0453 to main January 2, 2023 18:56
@hf-kklein hf-kklein marked this pull request as ready for review January 2, 2023 18:59

_subsequent_step_pattern = re.compile(r"^(?P<bool>(?:ja)|(?:nein))\s*(?P<subsequent_step_number>(?:\d+\*?)|ende)?")

_step_number_pattern = re.compile(_STEP_NUMBER_REGEX)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hab letztens mal aus gegebenen Anlass ein bisschen das re package durchforstet. Tatsächlich ist es ziemlich überflüssig selbst die compile-Funktion aufzurufen. Denn das Package ruft stets (d.h. z.B. bei .match(...)) eine interne compile-Funktion auf, die zusätzlich eine Cache-Funktion bietet. D.h. dass jedes Regex-Pattern immer nur einmal kompiliert und anschließend im internen Cache gespeichert wird.
Dennoch, ist für mich fein so.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wieder was gelernt ;)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wobei man dazu sagen muss, dass die cache-Größe auf 512 beschränkt ist. Man scheint das aber theoretisch auch vergößern zu können, wenn ich das richtig sehe.

@hf-kklein hf-kklein merged commit 40e0189 into main Jan 2, 2023
@hf-kklein hf-kklein deleted the graph014a branch January 2, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix E_0462: gray outer left cells

2 participants