-
Notifications
You must be signed in to change notification settings - Fork 1
Move optional dependencies from dev_requirements to pyproject.toml
#239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2511473
bf6e43a
5e96a73
d2fbd24
3c7a142
24e3b20
8a10469
0c23327
bc967ee
40f2533
8b60617
dfebbdb
4042f03
5100ea9
78133c7
a7fa789
6efa2b2
f73826f
43ac719
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # contains 1 lower case word per line which are ignored in the spell_check |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ envlist = | |
| linting | ||
| coverage | ||
| type_check | ||
| formatcheck | ||
| skip_missing_interpreters = True | ||
| skipsdist = True | ||
|
|
||
|
|
@@ -14,19 +15,19 @@ commands = python -m pip install --upgrade pip | |
| # the tests environment is called by the Github action that runs the unit tests | ||
| deps = | ||
| -r requirements.txt | ||
| -r dev_requirements/requirements-tests.txt | ||
| .[tests] | ||
| setenv = PYTHONPATH = {toxinidir}/src | ||
| commands = python -m pytest --basetemp={envtmpdir} {posargs} | ||
|
|
||
| [testenv:linting] | ||
| # the linting environment is called by the Github Action that runs the linter | ||
| deps = | ||
| -r requirements.txt | ||
| -r dev_requirements/requirements-linting.txt | ||
| .[linting] | ||
| # add your fixtures like e.g. pytest_datafiles here | ||
| setenv = PYTHONPATH = {toxinidir}/src | ||
| commands = | ||
| pylint ebdamame | ||
| pylint ebdamame --ignore=version.py | ||
| pylint main.py | ||
| # add single files (ending with .py) or packages here | ||
|
|
||
|
|
@@ -35,18 +36,35 @@ commands = | |
| setenv = PYTHONPATH = {toxinidir}/src | ||
| deps = | ||
| -r requirements.txt | ||
| -r dev_requirements/requirements-type_check.txt | ||
| .[type_check] | ||
| commands = | ||
| mypy --show-error-codes --strict src/ebdamame | ||
| mypy --show-error-codes unittests | ||
| mypy --show-error-codes main.py | ||
| # add single files (ending with .py) or packages here | ||
|
|
||
| [testenv:formatcheck] | ||
| deps = | ||
| .[formatting] | ||
| commands = | ||
| black . --check | ||
| isort . --check | ||
|
|
||
| [testenv:spell_check] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wenn wirihn hier einführen, können wir ihn im nächsten PR auch verwenden in der ci? |
||
| # the spellcheck environment checks the code for typos | ||
| setenv = PYTHONPATH = {toxinidir}/src | ||
| deps = | ||
| -r requirements.txt | ||
| .[spellcheck] | ||
| commands = | ||
| codespell --ignore-words=domain-specific-terms.txt src | ||
| codespell --ignore-words=domain-specific-terms.txt README.md | ||
|
|
||
| [testenv:coverage] | ||
| # the coverage environment is called by the Github Action that runs the coverage measurement | ||
| deps = | ||
| {[testenv:tests]deps} | ||
| -r dev_requirements/requirements-coverage.txt | ||
| .[coverage] | ||
| setenv = PYTHONPATH = {toxinidir}/src | ||
| commands = | ||
| coverage run -m pytest --basetemp={envtmpdir} {posargs} | ||
|
|
@@ -56,7 +74,7 @@ commands = | |
| [testenv:test_packaging] | ||
| skip_install = true | ||
| deps = | ||
| -r dev_requirements/requirements-packaging.txt | ||
| .[test_packaging] | ||
| commands = | ||
| python -m build | ||
| twine check dist/* | ||
|
|
@@ -68,7 +86,7 @@ deps = | |
| {[testenv:linting]deps} | ||
| {[testenv:type_check]deps} | ||
| {[testenv:coverage]deps} | ||
| -r dev_requirements/requirements-formatting.txt | ||
| .[formatting] | ||
| pip-tools | ||
| pre-commit | ||
| commands = | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hf-kklein ich glaube dass ding sorgt dafür dass dir die formatierung gerettet wird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erkenntnisse aus den Vergleichenden Ci-Wissenschaft, da war das selbe linter problem im catover tool aber ohne formatting problems^^