Simplify Table Loop by encapsulating peek/look behind logic#25
Merged
Simplify Table Loop by encapsulating peek/look behind logic#25
Conversation
hf-kklein
commented
Jan 11, 2023
hf-kklein
commented
Jan 11, 2023
Comment on lines
+93
to
+99
| @dataclasses.dataclass | ||
| class _EnhancedDocxTableLine: | ||
| """ | ||
| A structure that primarily contains a single row from a DOCX table but also meta information about previous and | ||
| following elements in the table. It gathers information that are not directly accessible when only looking at one | ||
| single row. | ||
| """ |
Contributor
Author
There was a problem hiding this comment.
Die idee bei diesem PR ist, dass wir die Probleme, die bisher in einer großen Loop gelöst werden auf zwei Methoden aufteilen.
- Einen Methode (die, die die
List[_EnhancedDocxTableLine]) returned macht die Zählerei (also abwechselnd upper/lower und dann ab Fix EBDs with"*"in step_number;Skipped: Error while scraping 'E_0047': Exactly one of the entries in sub_rows has to have check_result.result True(e.g. E_0047) #21 auch die erkennung der"*". Sie liefert sowas wie Meta-Information für die - andere Methode (
_handle_single_table), die sich jetzt nicht mehr um die "Loop-Bürokratie" kümmern muss. Die ganze "Schau was in vorigen Zeilen war/wo du bist/was noch kommt?" ist jetzt ausgelagert.
Damit
- trennen/entkoppeln wir die Probleme
- durch die Entkopplung vereinfachen wir die Tests
- erhöhen die Lesbarkeit
- verringern die Anzahl der Variablen (ein pylint-disable weniger)
hf-kklein
changed the title
lord-haffi
approved these changes
Jan 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.