Skip to content

fix(scraping): patch regex pattern for ebd table heading #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeltaDaniel merged 13 commits into from
Oct 28, 2024
Merged

fix(scraping): patch regex pattern for ebd table heading #258

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
81c0d24
added snapshots and new testdata
DeltaDaniel Oct 15, 2024
f622ac2
added snapshot tests
DeltaDaniel Oct 21, 2024
c6dd744
remove versionfile
DeltaDaniel Oct 21, 2024
8c2d992
updated tox.ini
DeltaDaniel Oct 21, 2024
4ef4ffe
Merge branch 'add_snapshot_tests' into 71-e_0400-v33-2023-06-19-docxt…
DeltaDaniel Oct 21, 2024
a12c2a2
Changed assignment of column indices
DeltaDaniel Oct 21, 2024
41361b1
updated snapshots
DeltaDaniel Oct 23, 2024
ae81723
updated regex
DeltaDaniel Oct 23, 2024
fd782a5
update snapshot
DeltaDaniel Oct 28, 2024
52b4e74
Merge remote-tracking branch 'origin/main' into patch_regex_for_ebd_t…
DeltaDaniel Oct 28, 2024
e235e37
fixed test
DeltaDaniel Oct 28, 2024
e8e0551
Update src/ebdamame/__init__.py
DeltaDaniel Oct 28, 2024
1564ade
added logger warning
DeltaDaniel Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ebdamame/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def _get_tables_and_paragraphs(document: DocumentType) -> Generator[Union[Table,


_ebd_key_pattern = re.compile(r"^E_\d{4}$")
_ebd_key_with_heading_pattern = re.compile(r"^(?P<key>E_\d{4})_(?P<title>.*)\s*$")
_ebd_key_with_heading_pattern = re.compile(r"^(?P<key>E_\d{4})(_?)(?P<title>.*)\s*$")
Comment thread
DeltaDaniel marked this conversation as resolved.
Outdated


class TableNotFoundError(Exception):
Expand Down
Loading